WIP: Store if registry was initialized #67

tback · 2018-02-22T15:35:53Z

This code is a work in progress. I'm opening the pull request this early to learn if you'd accept this when it's done?

Prometheus Authors (Brian) recommend to create zero value for metrics
known to exist in the future.

The usage pattern I want to enable is this:

$counter = $registry->registerCounter('namespace', 'metric', ['label_name']);
if(!$registry->initialized()){
    foreach($labelValues as $labelValue){
        $counter->incBy(0, [$labelValue]);
    }
}

Initialization is valid as for as long as the data exists in the storage
adapter.

Prometheus Authors (Brian) recommend to create zero value for metrics known to exist in the future. The usage pattern I want to enable is this: $counter = $registry->registerCounter('namespace', 'metric', ['label_name']); if(!$registry->initialized()){ foreach($labelValues as $labelValue){ $counter->incBy(0, [$labelValue]); } } Initialization is valid as for as long as the data exists in the storage adapter.

tback · 2018-03-13T08:03:27Z

It'd be great to know if this has a chance of getting accepted when it's done.

bracki · 2018-03-19T21:27:50Z

Would you mind adding a link to the post that describes the usage pattern you outlined above?

tback · 2018-03-20T08:24:20Z

There you go @bracki:
https://www.robustperception.io/existential-issues-with-metrics/
https://prometheus.io/docs/practices/instrumentation/#avoid-missing-metrics

bracki · 2018-03-20T10:06:27Z

I read the blog post you mentioned. I would rather not add it. If you need to do it, it should be possible to do it on your own.
In the example from the blog post a Java static initializer is used, which makes sure the code only runs once. I don't think we should fix the shortcomings of PHP within this library. It's more of a pattern than a feature.

tback · 2018-03-20T14:13:38Z

PHP doesn't provide a method to share data between requests out of the box. prometheus_client_php solves this shortcoming with storage adapters. Initializing metrics with 0 is a common usage pattern for prometheus and needs to share data between requests. Why is one inside the scope of this library, but the other one is not?

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: Store if registry was initialized #67

WIP: Store if registry was initialized #67

tback commented Feb 22, 2018

tback commented Mar 13, 2018

bracki commented Mar 19, 2018

tback commented Mar 20, 2018

bracki commented Mar 20, 2018

tback commented Mar 20, 2018 •

edited

Loading

WIP: Store if registry was initialized #67

Are you sure you want to change the base?

WIP: Store if registry was initialized #67

Conversation

tback commented Feb 22, 2018

tback commented Mar 13, 2018

bracki commented Mar 19, 2018

tback commented Mar 20, 2018

bracki commented Mar 20, 2018

tback commented Mar 20, 2018 • edited Loading

tback commented Mar 20, 2018 •

edited

Loading